Add transparent pseudo-element on active buttons for border in Windows High Contrast mode#11680
Add transparent pseudo-element on active buttons for border in Windows High Contrast mode#11680sabernhardt wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
What are your thoughts on applying a 3px border to all four sides, rather than just the bottom? 
|
2 participants
Adds a transparent pseudo-element on active buttons. In Windows High Contrast mode, this shows a thin border on three sides and a thicker border on the bottom.
Using a pseudo-element reduces the chance of confusion with the focus outline, and it does not change the border (and button height) for other users.
Trac 65153
Screenshots
Screenshots using:
Permalinks options, showing focus outline on selected post name button
Before
With patch (this also shows hover style on
post_idbutton)Alignment options
The 'None' button is selected.
Selected None button has focus outline
Before
With patch
Unselected Left button has focus outline
Before
With patch
Use of AI Tools
none
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.